From: Matthew Wilcox (Oracle) Date: Thu, 28 May 2026 17:31:30 +0000 (+0100) Subject: jbd2: Convert jbd2_write_superblock() to bh_submit() X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8a30f324e2cd93605038ee20ff25d0dec58839b6;p=thirdparty%2Flinux.git jbd2: Convert jbd2_write_superblock() to bh_submit() Avoid an extra indirect function call and changing the buffer refcount by using bh_submit() instead of submit_bh(). Signed-off-by: Matthew Wilcox (Oracle) Link: https://patch.msgid.link/20260528173150.1093780-18-willy@infradead.org Acked-by: Theodore Ts'o Reviewed-by: Jan Kara Cc: linux-ext4@vger.kernel.org Signed-off-by: Christian Brauner (Amutable) --- diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c index 4f397fcdb13c..2040af8c84cb 100644 --- a/fs/jbd2/journal.c +++ b/fs/jbd2/journal.c @@ -1820,9 +1820,7 @@ static int jbd2_write_superblock(journal_t *journal, blk_opf_t write_flags) } if (jbd2_journal_has_csum_v2or3(journal)) sb->s_checksum = jbd2_superblock_csum(sb); - get_bh(bh); - bh->b_end_io = end_buffer_write_sync; - submit_bh(REQ_OP_WRITE | write_flags, bh); + bh_submit(bh, REQ_OP_WRITE | write_flags, bh_end_write); wait_on_buffer(bh); if (buffer_write_io_error(bh)) { clear_buffer_write_io_error(bh);