From: Mahmoud Mandour <ma.mandourr@gmail.com>
Date: Fri, 30 Jul 2021 13:58:08 +0000 (+0200)
Subject: plugins/hotblocks: Added correct boolean argument parsing
X-Git-Tag: v6.2.0-rc0~118^2~10
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8a3eab66e62993228887588d753eefacc918184b;p=thirdparty%2Fqemu.git

plugins/hotblocks: Added correct boolean argument parsing

Signed-off-by: Mahmoud Mandour <ma.mandourr@gmail.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20210730135817.17816-5-ma.mandourr@gmail.com>
---

diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c
index 4b083401432..062200a7a42 100644
--- a/contrib/plugins/hotblocks.c
+++ b/contrib/plugins/hotblocks.c
@@ -133,8 +133,18 @@ QEMU_PLUGIN_EXPORT
 int qemu_plugin_install(qemu_plugin_id_t id, const qemu_info_t *info,
                         int argc, char **argv)
 {
-    if (argc && strcmp(argv[0], "inline") == 0) {
-        do_inline = true;
+    for (int i = 0; i < argc; i++) {
+        char *opt = argv[i];
+        g_autofree char **tokens = g_strsplit(opt, "=", 2);
+        if (g_strcmp0(tokens[0], "inline") == 0) {
+            if (!qemu_plugin_bool_parse(tokens[0], tokens[1], &do_inline)) {
+                fprintf(stderr, "boolean argument parsing failed: %s\n", opt);
+                return -1;
+            }
+        } else {
+            fprintf(stderr, "option parsing failed: %s\n", opt);
+            return -1;
+        }
     }
 
     plugin_init();