From: Jan Engelhardt <jengelh@medozas.de>
Date: Sun, 20 Feb 2011 19:30:56 +0000 (+0100)
Subject: libxt_quota: require --quota to be specified
X-Git-Tag: v1.4.11~61
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8a5270b14908b3173de080a958e50e21e2f046de;p=thirdparty%2Fiptables.git

libxt_quota: require --quota to be specified

It is pretty pointless to use -m quota without specifying --quota.
There would be nothing left to count down on.

Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
---

diff --git a/extensions/libxt_quota.c b/extensions/libxt_quota.c
index e6ed9bc7..e3699ad7 100644
--- a/extensions/libxt_quota.c
+++ b/extensions/libxt_quota.c
@@ -72,12 +72,19 @@ quota_parse(int c, char **argv, int invert, unsigned int *flags,
 
 		if (invert)
 			info->flags |= XT_QUOTA_INVERT;
-
+		*flags |= 1;
 		break;
 	}
 	return 1;
 }
 
+static void quota_check(unsigned int flags)
+{
+	if (flags == 0)
+		xtables_error(PARAMETER_PROBLEM,
+			"quota: the --quota argument must be specified\n");
+}
+
 static struct xtables_match quota_match = {
 	.family		= NFPROTO_UNSPEC,
 	.name		= "quota",
@@ -86,6 +93,7 @@ static struct xtables_match quota_match = {
 	.userspacesize	= offsetof(struct xt_quota_info, master),
 	.help		= quota_help,
 	.parse		= quota_parse,
+	.final_check	= quota_check,
 	.print		= quota_print,
 	.save		= quota_save,
 	.extra_opts	= quota_opts,