From: Alex Rousskov Date: Wed, 22 Sep 2010 23:04:40 +0000 (-0600) Subject: HTTP Compliance: do not remove ETag header from partial responses X-Git-Tag: take1~236 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8a5e74fcd81046a595724f7426b58ba19ce2184d;p=thirdparty%2Fsquid.git HTTP Compliance: do not remove ETag header from partial responses RFC 2616 section 10.2.7 says that partial responses MUST include ETag header if it would have been sent in a 200 response to the same request. Co-Advisor test cases: test_case/rfc2616/scHdrs-206-include-explicit-withVary-noIfs test_case/rfc2616/scHdrs-206-include-explicit-woutVary-noIfs test_case/rfc2616/scHdrs-206-include-other-If-Range-strong --- diff --git a/src/client_side.cc b/src/client_side.cc index e628863b8b..360b139453 100644 --- a/src/client_side.cc +++ b/src/client_side.cc @@ -1261,8 +1261,6 @@ ClientSocketContext::buildRangeHeader(HttpReply * rep) debugs(33, 3, "clientBuildRangeHeader: range spec count: " << spec_count << " virgin clen: " << rep->content_length); assert(spec_count > 0); - /* ETags should not be returned with Partial Content replies? */ - hdr->delById(HDR_ETAG); /* append appropriate header(s) */ if (spec_count == 1) {