From: Antonio Quartulli <a@unstable.cc>
Date: Thu, 19 Sep 2019 07:28:20 +0000 (+0200)
Subject: t_net.sh: wait for NO-CARRIER bit to settle before starting test
X-Git-Tag: v2.5_beta1~280
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8aa037161f37c42585ac4a8d99f37af624211da6;p=thirdparty%2Fopenvpn.git

t_net.sh: wait for NO-CARRIER bit to settle before starting test

Interfaces of type tun are marked as NO-CARRIER when no process is
attached to them. However, this bit gets set with some delay after
creation.

For this reason, it is better to wait for the bit to settle before
starting any test, otherwise any timing influence on the test may lead
to inconsistencies due to the NO-CARRIER bit randomly being or not in
the snapshot output taken by t_net.sh.

This patch add a 'sleep 1' command right after creation of the
interface, to give the NO-CARRIER bit a chance to settle.

This issue has been witnessed on a buildbot that is
apparently slowler than average to run the unit tests.

Signed-off-by: Antonio Quartulli <a@unstable.cc>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20190919072820.9913-1-a@unstable.cc>
URL: https://www.mail-archive.com/search?l=mid&q=20190919072820.9913-1-a@unstable.cc
Signed-off-by: Gert Doering <gert@greenie.muc.de>
---

diff --git a/tests/t_net.sh b/tests/t_net.sh
index 18799d127..97e947ab5 100755
--- a/tests/t_net.sh
+++ b/tests/t_net.sh
@@ -34,6 +34,13 @@ reload_dummy()
 {
     $RUN_SUDO $openvpn --dev $IFACE --dev-type tun --rmtun >/dev/null
     $RUN_SUDO $openvpn --dev $IFACE --dev-type tun --mktun >/dev/null
+
+    # it seems that tun devices will settle on NO-CARRIER while not connected to
+    # any process, but this won't happen immediately. To avoid having the
+    # NO-CARRIER bit appear in the middle of the tests - which would compromise
+    # the results - let's wait 1 sec here for it to settle.
+    sleep 1
+
     if [ $? -ne 0 ]; then
         echo "can't create interface $IFACE"
         exit 1