From: Amaury Denoyelle <adenoyelle@haproxy.com>
Date: Fri, 8 Aug 2025 13:12:59 +0000 (+0200)
Subject: BUG/MINOR: mux-h1: fix wrong lock label
X-Git-Tag: v3.3-dev7~21
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8ac54cafcda749a5b50532b3a10d39a5a37ce9b3;p=thirdparty%2Fhaproxy.git

BUG/MINOR: mux-h1: fix wrong lock label

Wrong lock label is used when manipulating idle lock on h1_timeout_task.
Fix this by replacing OTHER_LOCK by IDLE_CONNS_LOCK.

This only concerns thread debugging statistics.

This must be backported up to 2.4.
---

diff --git a/src/mux_h1.c b/src/mux_h1.c
index 839c9b9c3..67c55fd3b 100644
--- a/src/mux_h1.c
+++ b/src/mux_h1.c
@@ -4410,7 +4410,7 @@ struct task *h1_timeout_task(struct task *t, void *context, unsigned int state)
 			se_fl_set(h1c->h1s->sd, SE_FL_EOS | SE_FL_ERROR);
 			h1_alert(h1c->h1s);
 			h1_refresh_timeout(h1c);
-			HA_SPIN_UNLOCK(OTHER_LOCK, &idle_conns[tid].idle_conns_lock);
+			HA_SPIN_UNLOCK(IDLE_CONNS_LOCK, &idle_conns[tid].idle_conns_lock);
 			TRACE_DEVEL("waiting to release the SC before releasing the connection", H1_EV_H1C_WAKE);
 			return t;
 		}