From: Mukesh Ojha <mojha@codeaurora.org>
Date: Tue, 26 Mar 2019 12:17:54 +0000 (-0400)
Subject: media: vpss: fix the order of resource clean up
X-Git-Tag: v5.3-rc1~170^2~351
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8aef94beadc51c8fa768ef1d5ae5ca1b4c328eb0;p=thirdparty%2Fkernel%2Flinux.git

media: vpss: fix the order of resource clean up

Clean up of resources should be in reverse order of vpss_init().
Fix this inside vpss_exit().

Signed-off-by: Mukesh Ojha <mojha@codeaurora.org>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
---

diff --git a/drivers/media/platform/davinci/vpss.c b/drivers/media/platform/davinci/vpss.c
index 89a86c19579b8..b4ff3f1961a1e 100644
--- a/drivers/media/platform/davinci/vpss.c
+++ b/drivers/media/platform/davinci/vpss.c
@@ -507,9 +507,9 @@ static struct platform_driver vpss_driver = {
 
 static void vpss_exit(void)
 {
+	platform_driver_unregister(&vpss_driver);
 	iounmap(oper_cfg.vpss_regs_base2);
 	release_mem_region(VPSS_CLK_CTRL, 4);
-	platform_driver_unregister(&vpss_driver);
 }
 
 static int __init vpss_init(void)