From: Lenny Szubowicz Date: Tue, 27 Mar 2018 13:56:40 +0000 (-0400) Subject: ACPI: acpi_pad: Fix memory leak in power saving threads X-Git-Tag: v4.17-rc1~160^2~4 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8b29d29abc484d638213dd79a18a95ae7e5bb402;p=thirdparty%2Fkernel%2Flinux.git ACPI: acpi_pad: Fix memory leak in power saving threads Fix once per second (round_robin_time) memory leak of about 1 KB in each acpi_pad kernel idling thread that is activated. Found by testing with kmemleak. Signed-off-by: Lenny Szubowicz Signed-off-by: Rafael J. Wysocki --- diff --git a/drivers/acpi/acpi_pad.c b/drivers/acpi/acpi_pad.c index 7544310312825..552c1f725b6cf 100644 --- a/drivers/acpi/acpi_pad.c +++ b/drivers/acpi/acpi_pad.c @@ -110,6 +110,7 @@ static void round_robin_cpu(unsigned int tsk_index) cpumask_andnot(tmp, cpu_online_mask, pad_busy_cpus); if (cpumask_empty(tmp)) { mutex_unlock(&round_robin_lock); + free_cpumask_var(tmp); return; } for_each_cpu(cpu, tmp) { @@ -127,6 +128,8 @@ static void round_robin_cpu(unsigned int tsk_index) mutex_unlock(&round_robin_lock); set_cpus_allowed_ptr(current, cpumask_of(preferred_cpu)); + + free_cpumask_var(tmp); } static void exit_round_robin(unsigned int tsk_index)