From: Pavel Reichl <preichl@redhat.com>
Date: Fri, 27 May 2022 20:36:21 +0000 (-0400)
Subject: mkfs: Fix memory leak
X-Git-Tag: v5.18.0-rc1~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8b4002e0cd0072dd69d478ed662f7cf546bae33b;p=thirdparty%2Fxfsprogs-dev.git

mkfs: Fix memory leak

'value' is allocated by strdup() in getstr(). It
needs to be freed as we do not keep any permanent
reference to it.

Signed-off-by: Pavel Reichl <preichl@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 01d2e8cad..a37d6848a 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -1714,6 +1714,7 @@ naming_opts_parser(
 		} else {
 			cli->sb_feat.dir_version = getnum(value, opts, subopt);
 		}
+		free((char *)value);
 		break;
 	case N_FTYPE:
 		cli->sb_feat.dirftype = getnum(value, opts, subopt);