From: Ville Syrjälä Date: Thu, 2 May 2024 12:14:21 +0000 (+0300) Subject: drm/i915: Fix HAS_REGION() usage in intel_gt_probe_lmem() X-Git-Tag: v6.11-rc1~141^2~17^2~13 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8b69ac66d68907deb473b310b4f2c2a6b26ef191;p=thirdparty%2Fkernel%2Flinux.git drm/i915: Fix HAS_REGION() usage in intel_gt_probe_lmem() HAS_REGION() takes a bitmask, not the region ID. This causes the GEM_BUG_ON() to assert that the SMEM region is available rather than the intended LMEM region. No real harm since SMEM is always available, but also not checking what was intended. Signed-off-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/20240502121423.1002-1-ville.syrjala@linux.intel.com Reviewed-by: Rodrigo Vivi --- diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c index 45920cda0cc77..96b444905d8ce 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt.c +++ b/drivers/gpu/drm/i915/gt/intel_gt.c @@ -105,7 +105,7 @@ static int intel_gt_probe_lmem(struct intel_gt *gt) intel_memory_region_set_name(mem, "local%u", mem->instance); - GEM_BUG_ON(!HAS_REGION(i915, id)); + GEM_BUG_ON(!HAS_REGION(i915, BIT(id))); GEM_BUG_ON(i915->mm.regions[id]); i915->mm.regions[id] = mem;