From: Dan Carpenter <dan.carpenter@linaro.org>
Date: Thu, 15 Aug 2024 11:20:12 +0000 (+0300)
Subject: crypto: spacc - Fix NULL vs IS_ERR() check in spacc_aead_fallback()
X-Git-Tag: v6.12-rc1~231^2~49
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8bc1bfa02e37d63632f0cb65543e3e71acdccafb;p=thirdparty%2Fkernel%2Flinux.git

crypto: spacc - Fix NULL vs IS_ERR() check in spacc_aead_fallback()

The crypto_alloc_aead() function doesn't return NULL pointers, it returns
error pointers.  Fix the error checking.

Fixes: 06af76b46c78 ("crypto: spacc - Add SPAcc aead support")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
---

diff --git a/drivers/crypto/dwc-spacc/spacc_aead.c b/drivers/crypto/dwc-spacc/spacc_aead.c
index abf5971e919dc..7f6c48881eab2 100755
--- a/drivers/crypto/dwc-spacc/spacc_aead.c
+++ b/drivers/crypto/dwc-spacc/spacc_aead.c
@@ -769,9 +769,9 @@ static int spacc_aead_fallback(struct aead_request *req,
 	ctx->fb.aead = crypto_alloc_aead(aead_name, 0,
 					 CRYPTO_ALG_NEED_FALLBACK |
 					 CRYPTO_ALG_ASYNC);
-	if (!ctx->fb.aead) {
+	if (IS_ERR(ctx->fb.aead)) {
 		pr_err("Spacc aead fallback tfm is NULL!\n");
-		return -EINVAL;
+		return PTR_ERR(ctx->fb.aead);
 	}
 
 	subreq = aead_request_alloc(ctx->fb.aead, GFP_KERNEL);