From: Pauli <pauli@openssl.org>
Date: Mon, 26 Sep 2022 00:10:16 +0000 (+1000)
Subject: Coverity 1515538: resource leak
X-Git-Tag: openssl-3.2.0-alpha1~2008
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8bc703c2886c2104f1d472ab681bc7a8c081427a;p=thirdparty%2Fopenssl.git

Coverity 1515538: resource leak

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19275)
---

diff --git a/apps/pkcs12.c b/apps/pkcs12.c
index f4aef816dd4..0c39ed79bd4 100644
--- a/apps/pkcs12.c
+++ b/apps/pkcs12.c
@@ -687,8 +687,10 @@ int pkcs12_main(int argc, char **argv)
             if ((cb_sk = NCONF_get_section(conf, cb_attr)) != NULL) {
                 for (i = 0; i < sk_CONF_VALUE_num(cb_sk); i++) {
                     val = sk_CONF_VALUE_value(cb_sk, i);
-                    if (strcmp(val->name, "jdkTrustedKeyUsage") == 0)
+                    if (strcmp(val->name, "jdkTrustedKeyUsage") == 0) {
                         obj = OBJ_txt2obj(val->value, 0);
+                        break;
+                    }
                 }
             } else {
                 ERR_clear_error();