From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Thu, 18 Jul 2019 09:30:43 +0000 (+0200)
Subject: shared/conf-parser: emit a nicer warning for something like "======"
X-Git-Tag: v243-rc1~90^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8be8ed8ce1ed30450b6caf6e7dcf6dd28080e1f6;p=thirdparty%2Fsystemd.git

shared/conf-parser: emit a nicer warning for something like "======"

Urlich Windl wrote on the mailing list:
> I noticed that a line of "=======" in "[Service]" cases the message " Unknown lvalue '' in section 'Service'".

This now becomes:
/etc/systemd/system/eqeqeqeq.service:3: Missing key name before '=', ignoring line.
---

diff --git a/src/shared/conf-parser.c b/src/shared/conf-parser.c
index c3af2308703..b4ebc0f44bc 100644
--- a/src/shared/conf-parser.c
+++ b/src/shared/conf-parser.c
@@ -249,6 +249,9 @@ static int parse_line(
         if (!e)
                 return log_syntax(unit, LOG_WARNING, filename, line, 0,
                                   "Missing '=', ignoring line.");
+        if (e == l)
+                return log_syntax(unit, LOG_WARNING, filename, line, 0,
+                                  "Missing key name before '=', ignoring line.");
 
         *e = 0;
         e++;