From: Matthew Wilcox (Oracle) <willy@infradead.org>
Date: Thu, 30 May 2024 20:20:54 +0000 (+0100)
Subject: coda: Convert coda_symlink_filler() to use folio_end_read()
X-Git-Tag: v6.11-rc1~241^2~14
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8c30a7344abedf25002baed6196cf41b6fb75c0e;p=thirdparty%2Flinux.git

coda: Convert coda_symlink_filler() to use folio_end_read()

This is slightly more efficient than separate calls to
folio_mark_uptodate() and folio_unlock(), and it's easier to read.
Get rid of the call to folio_set_error() as nobody will check this flag.

Cc: Jan Harkes <jaharkes@cs.cmu.edu>
Cc: coda@cs.cmu.edu
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Link: https://lore.kernel.org/r/20240530202110.2653630-3-willy@infradead.org
Signed-off-by: Christian Brauner <brauner@kernel.org>
---

diff --git a/fs/coda/symlink.c b/fs/coda/symlink.c
index ccdbec388091a..40f84d0145247 100644
--- a/fs/coda/symlink.c
+++ b/fs/coda/symlink.c
@@ -31,15 +31,7 @@ static int coda_symlink_filler(struct file *file, struct folio *folio)
 	cii = ITOC(inode);
 
 	error = venus_readlink(inode->i_sb, &cii->c_fid, p, &len);
-	if (error)
-		goto fail;
-	folio_mark_uptodate(folio);
-	folio_unlock(folio);
-	return 0;
-
-fail:
-	folio_set_error(folio);
-	folio_unlock(folio);
+	folio_end_read(folio, error == 0);
 	return error;
 }