From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Tue, 14 May 2024 03:48:53 +0000 (-0600)
Subject: Explicitly free the listener in the socket destructor
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8c4d2ffa3042ce1f4d12cf9eb63db9dd07e47709;p=thirdparty%2Ffreeradius-server.git

Explicitly free the listener in the socket destructor
---

diff --git a/src/lib/io/network.c b/src/lib/io/network.c
index 632cb0ae19..72d00cb10c 100644
--- a/src/lib/io/network.c
+++ b/src/lib/io/network.c
@@ -1278,6 +1278,7 @@ static int _network_socket_free(fr_network_socket_t *s)
 	}
 
 	talloc_free(s->waiting);
+	talloc_free(s->listen);
 
 	return 0;
 }
diff --git a/src/listen/detail/proto_detail_work.c b/src/listen/detail/proto_detail_work.c
index 7bbaf09231..e3fc43546b 100644
--- a/src/listen/detail/proto_detail_work.c
+++ b/src/listen/detail/proto_detail_work.c
@@ -761,14 +761,6 @@ static int mod_close_internal(proto_detail_work_thread_t *thread)
 	close(thread->fd);
 	thread->fd = -1;
 
-	/*
-	 *	If we've been spawned from proto_detail_file, clean
-	 *	ourselves up, including our listener.
-	 */
-	if (thread->listen) {
-		talloc_free(thread->listen);
-	}
-
 	if (inst->parent->exit_when_done) {
 		INFO("Done reading detail files, process will now exit");