From: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Date: Tue, 26 Oct 2021 02:40:20 +0000 (+0000)
Subject: test/ssl_old_test.c: Do NULL pointer check before its use
X-Git-Tag: openssl-3.2.0-alpha1~3417
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8c590a219fe30b97cfde2efdd8ea94c03a90a8c6;p=thirdparty%2Fopenssl.git

test/ssl_old_test.c: Do NULL pointer check before its use

In openssl-3.0.0 and system provided, it is not reasonable to
check null pointer after use. The order was accidentally reversed.
Therefore, it is better to correct it.

CLA: trivial

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/16915)
---

diff --git a/test/ssl_old_test.c b/test/ssl_old_test.c
index 3ccc8e06e4c..6a206d595e3 100644
--- a/test/ssl_old_test.c
+++ b/test/ssl_old_test.c
@@ -1896,9 +1896,9 @@ int doit_localhost(SSL *s_ssl, SSL *c_ssl, int family, long count,
     BIO_snprintf(addr_str, sizeof(addr_str), ":%s", BIO_get_accept_port(acpt));
 
     client = BIO_new_connect(addr_str);
-    BIO_set_conn_ip_family(client, family);
     if (!client)
         goto err;
+    BIO_set_conn_ip_family(client, family);
 
     if (BIO_set_nbio(client, 1) <= 0)
         goto err;