From: Yu Kuai Date: Mon, 17 Nov 2025 08:55:56 +0000 (+0800) Subject: md: warn about updating super block failure X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8c9e376b9d1a222fa02b93b615d2e25be0a91fed;p=thirdparty%2Flinux.git md: warn about updating super block failure Many personalities will handle IO error from daemon thread(like raid1d, raid10d, raid5d), and sb will require to be clean before hanlding these failed IO. However update sb can fail, for example array is broken by IO failure, or user config sysfs api array_state. This patch adds warning if updating sb failed first, in case this will be related to IO hang. Link: https://lore.kernel.org/linux-raid/20251117085557.770572-2-yukuai@fnnas.com Signed-off-by: Yu Kuai Reviewed-by: Li Nan --- diff --git a/drivers/md/md.c b/drivers/md/md.c index 7b5c5967568fb..345b1e623abaf 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -2788,6 +2788,7 @@ void md_update_sb(struct mddev *mddev, int force_change) if (!md_is_rdwr(mddev)) { if (force_change) set_bit(MD_SB_CHANGE_DEVS, &mddev->sb_flags); + pr_err("%s: can't update sb for read-only array %s\n", __func__, mdname(mddev)); return; }