From: Marc-André Lureau Date: Thu, 28 Mar 2024 10:20:50 +0000 (+0400) Subject: hw/nvme: fix -Werror=maybe-uninitialized X-Git-Tag: v9.0.0-rc2~1^2~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8cdb368d19e6568a3b17e9b5202a66cc0e2587d8;p=thirdparty%2Fqemu.git hw/nvme: fix -Werror=maybe-uninitialized ../hw/nvme/ctrl.c:6081:21: error: ‘result’ may be used uninitialized [-Werror=maybe-uninitialized] It's not obvious that 'result' is set in all code paths. When &result is a returned argument, it's even less clear. Looking at various assignments, 0 seems to be a suitable default value. Signed-off-by: Marc-André Lureau Reviewed-by: Klaus Jensen Message-ID: <20240328102052.3499331-18-marcandre.lureau@redhat.com> Signed-off-by: Philippe Mathieu-Daudé --- diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index c2b17de9872..127c3d23834 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -5894,7 +5894,7 @@ static uint16_t nvme_get_feature(NvmeCtrl *n, NvmeRequest *req) uint32_t dw10 = le32_to_cpu(cmd->cdw10); uint32_t dw11 = le32_to_cpu(cmd->cdw11); uint32_t nsid = le32_to_cpu(cmd->nsid); - uint32_t result; + uint32_t result = 0; uint8_t fid = NVME_GETSETFEAT_FID(dw10); NvmeGetFeatureSelect sel = NVME_GETFEAT_SELECT(dw10); uint16_t iv;