From: Pauli <ppzgs1@gmail.com>
Date: Thu, 18 Mar 2021 23:35:05 +0000 (+1000)
Subject: apps: fix coverity 1455340: unchecked return value
X-Git-Tag: openssl-3.0.0-alpha14~130
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8cdcb63fc02239e92fc4bdcc5b97d38cc726c439;p=thirdparty%2Fopenssl.git

apps: fix coverity 1455340: unchecked return value

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14615)
---

diff --git a/apps/lib/s_cb.c b/apps/lib/s_cb.c
index 4c209e76dfa..6824567c708 100644
--- a/apps/lib/s_cb.c
+++ b/apps/lib/s_cb.c
@@ -1276,12 +1276,14 @@ int config_ctx(SSL_CONF_CTX *cctx, STACK_OF(OPENSSL_STRING) *str,
 static int add_crls_store(X509_STORE *st, STACK_OF(X509_CRL) *crls)
 {
     X509_CRL *crl;
-    int i;
+    int i, ret = 1;
+
     for (i = 0; i < sk_X509_CRL_num(crls); i++) {
         crl = sk_X509_CRL_value(crls, i);
-        X509_STORE_add_crl(st, crl);
+        if (!X509_STORE_add_crl(st, crl))
+            ret = 0;
     }
-    return 1;
+    return ret;
 }
 
 int ssl_ctx_add_crls(SSL_CTX *ctx, STACK_OF(X509_CRL) *crls, int crl_download)