From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Date: Mon, 30 Nov 2020 12:49:15 +0000 (+0100)
Subject: printk: remove obsolete dead assignment
X-Git-Tag: v5.11-rc1~125^2^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8d143c610b62f2820fbc97dc441d54ac326abe1a;p=thirdparty%2Fkernel%2Flinux.git

printk: remove obsolete dead assignment

Commit 849f3127bb46 ("switch /dev/kmsg to ->write_iter()") refactored
devkmsg_write() and left over a dead assignment on the variable 'len'.

Hence, make clang-analyzer warns:

  kernel/printk/printk.c:744:4: warning: Value stored to 'len' is never read
    [clang-analyzer-deadcode.DeadStores]
                          len -= endp - line;
                          ^

Simply remove this obsolete dead assignment here.

Link: https://lore.kernel.org/r/20201130124915.7573-1-lukas.bulwahn@gmail.com
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
---

diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index fe64a49344bf5..6bffb01431dd2 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -741,7 +741,6 @@ static ssize_t devkmsg_write(struct kiocb *iocb, struct iov_iter *from)
 			if (LOG_FACILITY(u) != 0)
 				facility = LOG_FACILITY(u);
 			endp++;
-			len -= endp - line;
 			line = endp;
 		}
 	}