From: Michael Tremer <michael.tremer@ipfire.org>
Date: Wed, 23 Oct 2024 10:27:06 +0000 (+0000)
Subject: pakfire: Don't assign r when it not being read
X-Git-Tag: 0.9.30~936
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8d4db85bb390e1950fe1009debba422a9501a129;p=pakfire.git

pakfire: Don't assign r when it not being read

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/libpakfire/pakfire.c b/src/libpakfire/pakfire.c
index d517df842..36a70a9be 100644
--- a/src/libpakfire/pakfire.c
+++ b/src/libpakfire/pakfire.c
@@ -1240,6 +1240,7 @@ void pakfire_pool_internalize(struct pakfire* pakfire) {
 }
 
 PAKFIRE_EXPORT struct pakfire_repolist* pakfire_get_repos(struct pakfire* pakfire) {
+	struct pakfire_repo* repo = NULL;
 	struct pakfire_repolist* list;
 
 	int r = pakfire_repolist_create(&list);
@@ -1255,12 +1256,12 @@ PAKFIRE_EXPORT struct pakfire_repolist* pakfire_get_repos(struct pakfire* pakfir
 		if (strcmp(solv_repo->name, PAKFIRE_REPO_DUMMY) == 0)
 			continue;
 
-		struct pakfire_repo* repo = pakfire_repo_create_from_repo(pakfire, solv_repo);
-		if (!repo) {
-			r = 1;
+		// Create repository
+		repo = pakfire_repo_create_from_repo(pakfire, solv_repo);
+		if (!repo)
 			goto ERROR;
-		}
 
+		// Append it to the list
 		r = pakfire_repolist_append(list, repo);
 		if (r) {
 			pakfire_repo_unref(repo);