From: Eric Sandeen Date: Mon, 3 Aug 2015 22:36:41 +0000 (+1000) Subject: xfs_repair: Fix malloc size of rt_ext_tree_ptr X-Git-Tag: v4.2.0-rc1~1^2~2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8d8a27c2ddf7489d6608e10bc6cf5f168c51f1c7;p=thirdparty%2Fxfsprogs-dev.git xfs_repair: Fix malloc size of rt_ext_tree_ptr rt_ext_tree_ptr points to an avl64tree_desc_t, but we malloc memory according to the size of avltree_desc_t. Oddly, the latter happens to be larger, so we're ok, but may as well make it correct. Addresses-Coverity-Id: 1297533 Signed-off-by: Eric Sandeen Reviewed-by: Dave Chinner Signed-off-by: Dave Chinner --- diff --git a/repair/incore_ext.c b/repair/incore_ext.c index 826bf44b2..6611d5ce2 100644 --- a/repair/incore_ext.c +++ b/repair/incore_ext.c @@ -783,7 +783,7 @@ incore_ext_init(xfs_mount_t *mp) avl_init_tree(extent_bcnt_ptrs[i], &avl_extent_bcnt_tree_ops); } - if ((rt_ext_tree_ptr = malloc(sizeof(avltree_desc_t))) == NULL) + if ((rt_ext_tree_ptr = malloc(sizeof(avl64tree_desc_t))) == NULL) do_error(_("couldn't malloc dup rt extent tree descriptor\n")); avl64_init_tree(rt_ext_tree_ptr, &avl64_extent_tree_ops);