From: Andrei Coardos Date: Fri, 28 Jul 2023 18:20:09 +0000 (+0300) Subject: gpio: rc5t583: remove unneeded call to platform_set_drvdata() X-Git-Tag: v6.6-rc1~164^2~46 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8e85d6af1b3ceb619098c6b8a9f38e9e006e9c09;p=thirdparty%2Fkernel%2Flinux.git gpio: rc5t583: remove unneeded call to platform_set_drvdata() This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file. Reviewed-by: Alexandru Ardelean Signed-off-by: Andrei Coardos Reviewed-by: Andy Shevchenko Signed-off-by: Bartosz Golaszewski --- diff --git a/drivers/gpio/gpio-rc5t583.c b/drivers/gpio/gpio-rc5t583.c index 4fae3ebea7909..c34dcadaee36d 100644 --- a/drivers/gpio/gpio-rc5t583.c +++ b/drivers/gpio/gpio-rc5t583.c @@ -121,8 +121,6 @@ static int rc5t583_gpio_probe(struct platform_device *pdev) if (pdata && pdata->gpio_base) rc5t583_gpio->gpio_chip.base = pdata->gpio_base; - platform_set_drvdata(pdev, rc5t583_gpio); - return devm_gpiochip_add_data(&pdev->dev, &rc5t583_gpio->gpio_chip, rc5t583_gpio); }