From: Liang He Date: Fri, 22 Jul 2022 14:18:01 +0000 (+0800) Subject: ASoC: audio-graph-card2: Add of_node_put() in fail path X-Git-Tag: v6.0-rc1~93^2~8^2~14 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8ebc4dd8250fd1cb5da2869c0fe6ae3686fe41e9;p=thirdparty%2Fkernel%2Flinux.git ASoC: audio-graph-card2: Add of_node_put() in fail path In asoc_simple_parse_dai(), we should call of_node_put() for the reference returned by of_graph_get_port_parent() in fail path. Fixes: 6e5f68fe3f2d ("ASoC: add Audio Graph Card2 driver") Signed-off-by: Liang He Link: https://lore.kernel.org/r/20220722141801.1304854-1-windhl@126.com Signed-off-by: Mark Brown --- diff --git a/sound/soc/generic/audio-graph-card2.c b/sound/soc/generic/audio-graph-card2.c index 18d053a0d05c7..8ac6df645ee6c 100644 --- a/sound/soc/generic/audio-graph-card2.c +++ b/sound/soc/generic/audio-graph-card2.c @@ -445,8 +445,10 @@ static int asoc_simple_parse_dai(struct device_node *ep, * if he unbinded CPU or Codec. */ ret = snd_soc_get_dai_name(&args, &dlc->dai_name); - if (ret < 0) + if (ret < 0) { + of_node_put(node); return ret; + } dlc->of_node = node;