From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Fri, 3 Feb 2017 02:48:13 +0000 (+0100)
Subject: completion tests: check __gitdir()'s output in the error cases
X-Git-Tag: v2.13.0-rc0~170^2~17
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8f0fa85d4d21b67f80d408dd75b35623d829511e;p=thirdparty%2Fgit.git

completion tests: check __gitdir()'s output in the error cases

The __gitdir() helper function shouldn't output anything if not in a
git repository.  The relevant tests only checked its error code, so
extend them to ensure that there's no output.

Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh
index 030a16e778..f7f7d49fba 100755
--- a/t/t9902-completion.sh
+++ b/t/t9902-completion.sh
@@ -215,8 +215,9 @@ test_expect_success '__gitdir - non-existing $GIT_DIR' '
 	(
 		GIT_DIR="$ROOT/non-existing" &&
 		export GIT_DIR &&
-		test_must_fail __gitdir
-	)
+		test_must_fail __gitdir >"$actual"
+	) &&
+	test_must_be_empty "$actual"
 '
 
 test_expect_success '__gitdir - gitfile in cwd' '
@@ -255,7 +256,8 @@ test_expect_success SYMLINKS '__gitdir - resulting path avoids symlinks' '
 '
 
 test_expect_success '__gitdir - not a git repository' '
-	nongit test_must_fail __gitdir
+	nongit test_must_fail __gitdir >"$actual" &&
+	test_must_be_empty "$actual"
 '
 
 test_expect_success '__gitcomp - trailing space - options' '