From: Steven Rostedt Date: Tue, 21 Jan 2025 20:13:36 +0000 (-0500) Subject: tracing: Fix output of set_event for some cached module events X-Git-Tag: v6.14-rc1~124^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8f21943e101a15f56a8f02970a80edc936de8ec8;p=thirdparty%2Fkernel%2Flinux.git tracing: Fix output of set_event for some cached module events The following works fine: ~# echo ':mod:trace_events_sample' > /sys/kernel/tracing/set_event ~# cat /sys/kernel/tracing/set_event *:*:mod:trace_events_sample ~# But if a name is given without a ':' where it can match an event name or system name, the output of the cached events does not include a new line: ~# echo 'foo_bar:mod:trace_events_sample' > /sys/kernel/tracing/set_event ~# cat /sys/kernel/tracing/set_event foo_bar:mod:trace_events_sample~# Add the '\n' to that as well. Cc: Masami Hiramatsu Cc: Mathieu Desnoyers Link: https://lore.kernel.org/20250121151336.6c491844@gandalf.local.home Fixes: b355247df104e ("tracing: Cache ":mod:" events for modules not loaded yet") Signed-off-by: Steven Rostedt (Google) --- diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c index 5217dcddcb4c7..a9d7d02bbb203 100644 --- a/kernel/trace/trace_events.c +++ b/kernel/trace/trace_events.c @@ -1634,7 +1634,7 @@ static int s_show(struct seq_file *m, void *v) /* When match is set, system and event are not */ if (iter->event_mod->match) { - seq_printf(m, "%s:mod:%s", iter->event_mod->match, + seq_printf(m, "%s:mod:%s\n", iter->event_mod->match, iter->event_mod->module); return 0; }