From: Christophe JAILLET Date: Thu, 26 Dec 2019 14:54:35 +0000 (+0100) Subject: HID: logitech-hidpp: avoid duplicate error handling code in 'hidpp_probe()' X-Git-Tag: v5.6-rc1~198^2^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8f2828d737241be558b9d31c6c0465595a014341;p=thirdparty%2Flinux.git HID: logitech-hidpp: avoid duplicate error handling code in 'hidpp_probe()' 'hid_hw_stop()' is already in the error handling path when branching to the 'hid_hw_open_fail' label. There is no point in calling it twice, so remove one. Signed-off-by: Christophe JAILLET Signed-off-by: Jiri Kosina --- diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index bb063e7d48df2..70e1cb928bf03 100644 --- a/drivers/hid/hid-logitech-hidpp.c +++ b/drivers/hid/hid-logitech-hidpp.c @@ -3817,7 +3817,6 @@ static int hidpp_probe(struct hid_device *hdev, const struct hid_device_id *id) if (ret < 0) { dev_err(&hdev->dev, "%s:hid_hw_open returned error:%d\n", __func__, ret); - hid_hw_stop(hdev); goto hid_hw_open_fail; }