From: Raymond Hettinger <rhettinger@users.noreply.github.com>
Date: Sat, 2 Jan 2021 20:09:56 +0000 (-0800)
Subject: No need to test "istep==1" twice. (GH-24064)
X-Git-Tag: v3.10.0a4~18
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8f8de7380cd7fee4972a10240ad2b0fdc332b14d;p=thirdparty%2FPython%2Fcpython.git

No need to test "istep==1" twice. (GH-24064)
---

diff --git a/Lib/random.py b/Lib/random.py
index 97495f0985e7..4142e2e860c8 100644
--- a/Lib/random.py
+++ b/Lib/random.py
@@ -351,9 +351,9 @@ class Random(_random.Random):
                       DeprecationWarning, 2)
                 raise ValueError("non-integer step for randrange()")
         width = istop - istart
-        if istep == 1 and width > 0:
-            return istart + self._randbelow(width)
         if istep == 1:
+            if width > 0:
+                return istart + self._randbelow(width)
             raise ValueError("empty range for randrange() (%d, %d, %d)" % (istart, istop, width))
 
         # Non-unit step argument supplied.
@@ -363,10 +363,8 @@ class Random(_random.Random):
             n = (width + istep + 1) // istep
         else:
             raise ValueError("zero step for randrange()")
-
         if n <= 0:
             raise ValueError("empty range for randrange()")
-
         return istart + istep * self._randbelow(n)
 
     def randint(self, a, b):