From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Mon, 17 Jul 2023 20:54:54 +0000 (-0400)
Subject: Include <limits.h> in fe-auth.c, to get CHAR_BIT reliably.
X-Git-Tag: REL_17_BETA1~2120
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8fab4b34801331f1c59352cb0a248be436b60aef;p=thirdparty%2Fpostgresql.git

Include <limits.h> in fe-auth.c, to get CHAR_BIT reliably.

fe-auth.c references CHAR_BIT since commit 3a465cc67, but it
did not #include <limits.h>, which per POSIX is where that
symbol is defined.  This escaped notice so far because
(a) on most platforms, <sys/param.h> pulls in <limits.h>,
(b) even if yours doesn't, OpenSSL pulls it in, so compiling
with --with-openssl masks the omission.

Per bug #18026 from Marcel Hofstetter.  Back-patch to v16.

Discussion: https://postgr.es/m/18026-d5bb69f79cd16203@postgresql.org
---

diff --git a/src/interfaces/libpq/fe-auth.c b/src/interfaces/libpq/fe-auth.c
index 3ed8c6c89ba..887ca5e9e1b 100644
--- a/src/interfaces/libpq/fe-auth.c
+++ b/src/interfaces/libpq/fe-auth.c
@@ -27,6 +27,7 @@
 #else
 #include <unistd.h>
 #include <fcntl.h>
+#include <limits.h>
 #include <sys/param.h>			/* for MAXHOSTNAMELEN on most */
 #include <sys/socket.h>
 #ifdef HAVE_SYS_UCRED_H