From: Rob Herring (Arm) Date: Thu, 9 Jan 2025 18:21:17 +0000 (-0600) Subject: net: dsa: qca8k: Use of_property_present() for non-boolean properties X-Git-Tag: v6.14-rc1~162^2~103 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9007d911f6d2a99d3dd1dbf2097de35727cc665a;p=thirdparty%2Fkernel%2Flinux.git net: dsa: qca8k: Use of_property_present() for non-boolean properties The use of of_property_read_bool() for non-boolean properties is deprecated in favor of of_property_present() when testing for property presence. Signed-off-by: Rob Herring (Arm) Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller --- diff --git a/drivers/net/dsa/qca/qca8k-8xxx.c b/drivers/net/dsa/qca/qca8k-8xxx.c index 2d56a81524208..750fc76a6e116 100644 --- a/drivers/net/dsa/qca/qca8k-8xxx.c +++ b/drivers/net/dsa/qca/qca8k-8xxx.c @@ -1019,7 +1019,7 @@ qca8k_setup_mdio_bus(struct qca8k_priv *priv) of_get_phy_mode(port, &mode); - if (of_property_read_bool(port, "phy-handle") && + if (of_property_present(port, "phy-handle") && mode != PHY_INTERFACE_MODE_INTERNAL) external_mdio_mask |= BIT(reg); else