From: Amaury Denoyelle <adenoyelle@haproxy.com>
Date: Thu, 21 Aug 2025 12:16:58 +0000 (+0200)
Subject: BUG/MEDIUM: mux-h2: fix crash on idle-ping due to unwanted ABORT_NOW
X-Git-Tag: v3.3-dev8~124
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=901de11157bff8bf7a6ac560b16afb6c106746db;p=thirdparty%2Fhaproxy.git

BUG/MEDIUM: mux-h2: fix crash on idle-ping due to unwanted ABORT_NOW

An ABORT_NOW() was used during debugging idle-ping but was not removed
from the final code. This may cause crash, in particular when mixing
idle-ping with shorter http-request/http-keep-alive values.

Fix this situation by removing ABORT_NOW() statement.

This should fix github issue #3079.

This must be backported up to 3.2.
---

diff --git a/src/mux_h2.c b/src/mux_h2.c
index 65eb133e5..9ae45d261 100644
--- a/src/mux_h2.c
+++ b/src/mux_h2.c
@@ -924,7 +924,6 @@ static void h2c_update_timeout(struct h2c *h2c)
 					else if (h2c->flags & H2_CF_IDL_PING_SENT) {
 						/* timer other than ping selected, remove ping flag to allow GOAWAY on expiration. */
 						h2c->flags &= ~H2_CF_IDL_PING_SENT;
-						ABORT_NOW();
 					}
 				}
 			}