From: Thomas Huth Date: Thu, 17 Aug 2023 12:56:00 +0000 (+0200) Subject: hw/net/vmxnet3: Fix guest-triggerable assert() X-Git-Tag: v8.2.0-rc0~135^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=90a0778421acdf4ca903be64c8ed19378183c944;p=thirdparty%2Fqemu.git hw/net/vmxnet3: Fix guest-triggerable assert() The assert() that checks for valid MTU sizes can be triggered by the guest (e.g. with the reproducer code from the bug ticket https://gitlab.com/qemu-project/qemu/-/issues/517 ). Let's avoid this problem by simply logging the error and refusing to activate the device instead. Fixes: d05dcd94ae ("net: vmxnet3: validate configuration values during activate") Signed-off-by: Thomas Huth Cc: qemu-stable@nongnu.org Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Michael Tokarev [Mjt: change format specifier from %d to %u for uint32_t argument] --- diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 5dfacb10985..3fb108751a2 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c @@ -1439,7 +1439,10 @@ static void vmxnet3_activate_device(VMXNET3State *s) vmxnet3_setup_rx_filtering(s); /* Cache fields from shared memory */ s->mtu = VMXNET3_READ_DRV_SHARED32(d, s->drv_shmem, devRead.misc.mtu); - assert(VMXNET3_MIN_MTU <= s->mtu && s->mtu <= VMXNET3_MAX_MTU); + if (s->mtu < VMXNET3_MIN_MTU || s->mtu > VMXNET3_MAX_MTU) { + qemu_log_mask(LOG_GUEST_ERROR, "vmxnet3: Bad MTU size: %u\n", s->mtu); + return; + } VMW_CFPRN("MTU is %u", s->mtu); s->max_rx_frags =