From: Joseph Myers <joseph@codesourcery.com>
Date: Thu, 27 Nov 2014 16:00:08 +0000 (+0000)
Subject: Fix dlfcn/failtestmod.c warning.
X-Git-Tag: glibc-2.21~313
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9114625bad23441c89eac5a7dcf319a9714ca31f;p=thirdparty%2Fglibc.git

Fix dlfcn/failtestmod.c warning.

This patch fixes a "set but not used" warning from
dlfcn/failtestmod.c.  A variable is used only to store the return
value from dlsym.  As I understand this test, the point is simply to
do a sequence of load / unload operations in a loop, and all that
matters here is that dlsym gets called and returns without crashing,
not what its return value is.  So this patch removes the assignment to
a variable.

Tested for x86_64.

	* dlfcn/failtestmod.c (constr): Do not store result of dlsym in a
	variable.
---

diff --git a/ChangeLog b/ChangeLog
index 92ffe16bd63..9090877c86d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2014-11-27  Joseph Myers  <joseph@codesourcery.com>
+
+	* dlfcn/failtestmod.c (constr): Do not store result of dlsym in a
+	variable.
+
 2014-11-27  Stefan Liebler  <stli@linux.vnet.ibm.com>
 
 	* nscd/connections.c: Include libc-internal.h because of macro
diff --git a/dlfcn/failtestmod.c b/dlfcn/failtestmod.c
index a03f90b7341..64dadd53ff8 100644
--- a/dlfcn/failtestmod.c
+++ b/dlfcn/failtestmod.c
@@ -8,7 +8,6 @@ __attribute__ ((__constructor__))
 constr (void)
 {
   void *handle;
-  void *m;
 
   /* Open the library.  */
   handle = dlopen (NULL, RTLD_NOW);
@@ -19,7 +18,7 @@ constr (void)
     }
 
   /* Get a symbol.  */
-  m = dlsym (handle, "main");
+  dlsym (handle, "main");
   puts ("called dlsym() to get main");
 
   dlclose (handle);