From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Fri, 3 Jul 2015 10:43:33 +0000 (+0200)
Subject: Fix CID 740323: unchecked lseek return value in disk.cc
X-Git-Tag: merge-candidate-3-v1~62
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=914fbbba000d38e68a2e111b39344d1f9694b33a;p=thirdparty%2Fsquid.git

Fix CID 740323: unchecked lseek return value in disk.cc
---

diff --git a/src/disk.cc b/src/disk.cc
index a5ee680909..67dec9c45d 100644
--- a/src/disk.cc
+++ b/src/disk.cc
@@ -219,8 +219,13 @@ diskHandleWrite(int fd, void *)
 
     errno = 0;
 
-    if (fdd->write_q->file_offset != -1)
-        lseek(fd, fdd->write_q->file_offset, SEEK_SET); /* XXX ignore return? */
+    if (fdd->write_q->file_offset != -1) {
+        errno = 0;
+        if (lseek(fd, fdd->write_q->file_offset, SEEK_SET) == -1) {
+            debugs(50, DBG_IMPORTANT, "error in seek for fd " << fd << ": " << xstrerror());
+            // XXX: handle error?
+        }
+    }
 
     len = FD_WRITE_METHOD(fd,
                           fdd->write_q->buf + fdd->write_q->buf_offset,