From: Gary Benson Date: Mon, 13 Jul 2020 14:14:07 +0000 (+0100) Subject: Fix gdb.arch/i386-sse.exp with clang X-Git-Tag: gdb-10-branchpoint~745 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=915771bb8a8c14fce7af0d45967b955d0adc830b;p=thirdparty%2Fbinutils-gdb.git Fix gdb.arch/i386-sse.exp with clang gdb.arch/i386-sse.exp fails to run with clang, because of: gdb compile failed, /gdbtest/src/gdb/testsuite/gdb.arch/i386-sse.c:56:40: warning: passing 'int *' to parameter of type 'unsigned int *' converts between pointers to integer types with different sign [-Wpointer-sign] if (!x86_cpuid (1, NULL, NULL, NULL, &edx)) ^~~~ /gdbtest/src/gdb/testsuite/../nat/x86-cpuid.h:35:41: note: passing argument to parameter '__edx' here unsigned int *__ecx, unsigned int *__edx) ^ 1 warning generated. Fix it by declaring edx unsigned. gdb/testsuite/ChangeLog: * gdb.arch/i386-sse.c (have_sse) : Make unsigned. --- diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index fc9dcac563a..8fa0a46c9e0 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2020-07-13 Gary Benson + + * gdb.arch/i386-sse.c (have_sse) : Make unsigned. + 2020-07-13 Gary Benson * gdb.base/bigcore.c (main): Use a volatile pointer when diff --git a/gdb/testsuite/gdb.arch/i386-sse.c b/gdb/testsuite/gdb.arch/i386-sse.c index 72250e024f3..bd9bc1aff37 100644 --- a/gdb/testsuite/gdb.arch/i386-sse.c +++ b/gdb/testsuite/gdb.arch/i386-sse.c @@ -51,7 +51,7 @@ v4sf_t data[] = int have_sse (void) { - int edx; + unsigned int edx; if (!x86_cpuid (1, NULL, NULL, NULL, &edx)) return 0;