From: Philippe Mathieu-Daudé Date: Wed, 3 Jun 2020 17:59:16 +0000 (+0200) Subject: hw/sd/sdcard: Restrict Class 6 commands to SCSD cards X-Git-Tag: v5.1.0-rc0~4^2~4 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9157dd597d293ab7f599f4d96c3fe8a6e07c633d;p=thirdparty%2Fqemu.git hw/sd/sdcard: Restrict Class 6 commands to SCSD cards Only SCSD cards support Class 6 (Block Oriented Write Protection) commands. "SD Specifications Part 1 Physical Layer Simplified Spec. v3.01" 4.3.14 Command Functional Difference in Card Capacity Types * Write Protected Group SDHC and SDXC do not support write-protected groups. Issuing CMD28, CMD29 and CMD30 generates the ILLEGAL_COMMAND error. Cc: qemu-stable@nongnu.org Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-Id: <20200630133912.9428-7-f4bug@amsat.org> --- diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 5137168d661..1cc16bfd312 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -920,6 +920,11 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req) sd->multi_blk_cnt = 0; } + if (sd_cmd_class[req.cmd] == 6 && FIELD_EX32(sd->ocr, OCR, CARD_CAPACITY)) { + /* Only Standard Capacity cards support class 6 commands */ + return sd_illegal; + } + switch (req.cmd) { /* Basic commands (Class 0 and Class 1) */ case 0: /* CMD0: GO_IDLE_STATE */