From: Gao feng <gaofeng@cn.fujitsu.com>
Date: Tue, 29 Oct 2013 06:19:35 +0000 (+0800)
Subject: LXC: don't free tty before using it in lxcContainerSetupDevices
X-Git-Tag: v1.1.4-rc2~21
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=919374c73e4efa185d4303281b2071f654cb052c;p=thirdparty%2Flibvirt.git

LXC: don't free tty before using it in lxcContainerSetupDevices

Introduced by commit 0f31f7b.

Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
Signed-off-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c
index 1ec59d5c6e..255c7114d2 100644
--- a/src/lxc/lxc_container.c
+++ b/src/lxc/lxc_container.c
@@ -1042,10 +1042,10 @@ static int lxcContainerSetupDevices(char **ttyPaths, size_t nttyPaths)
         if (virAsprintf(&tty, "/dev/tty%zu", i+1) < 0)
             return -1;
         if (symlink(ttyPaths[i], tty) < 0) {
-            VIR_FREE(tty);
             virReportSystemError(errno,
                                  _("Failed to symlink %s to %s"),
                                  ttyPaths[i], tty);
+            VIR_FREE(tty);
             return -1;
         }
         VIR_FREE(tty);