From: David Carlier <dcarlier@afilias.info>
Date: Fri, 17 Nov 2017 08:47:25 +0000 (+0000)
Subject: BUG/MEDIUM: deviceatlas: ignore not valuable HTTP request data
X-Git-Tag: v1.8-rc4~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=91a88b0c2568a28c4c830a7eb10c3d8fb5b1e8cb;p=thirdparty%2Fhaproxy.git

BUG/MEDIUM: deviceatlas: ignore not valuable HTTP request data

A customer reported a crash when within the HTTP request some headers
were not set leading to the module to crash. So the module ignore them
since empty data have no value for the detection.
Needs to be backported to 1.7.
---

diff --git a/src/da.c b/src/da.c
index c31855d52f..09b0e3ec94 100644
--- a/src/da.c
+++ b/src/da.c
@@ -318,7 +318,7 @@ static int da_haproxy_fetch(const struct arg *args, struct sample *smp, const ch
 		char hbuf[24] = { 0 };
 
 		/* The HTTP headers used by the DeviceAtlas API are not longer */
-		if (hctx.del >= sizeof(hbuf)) {
+		if (hctx.del >= sizeof(hbuf) || hctx.del <= 0 || hctx.vlen <= 0) {
 			continue;
 		}