From: Jeff King <peff@peff.net>
Date: Tue, 24 Sep 2024 21:51:24 +0000 (-0400)
Subject: connect: clear child process before freeing in diagnostic mode
X-Git-Tag: v2.47.0-rc1~2^2~24
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=91aa67353971e994596e9cae77d6ec1d8feefa84;p=thirdparty%2Fgit.git

connect: clear child process before freeing in diagnostic mode

The git_connect() function has a special CONNECT_DIAG_URL mode, where we
stop short of actually connecting to the other side and just print some
parsing details. For URLs that require a child process (like ssh), we
free() the child_process struct but forget to clear it, leaking the
strings we stuffed into its "env" list.

This leak is triggered many times in t5500, which uses "fetch-pack
--diag-url", but we're not yet ready to mark it as leak-free.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/connect.c b/connect.c
index 6829ab3974..58f53d8dcb 100644
--- a/connect.c
+++ b/connect.c
@@ -1485,6 +1485,7 @@ struct child_process *git_connect(int fd[2], const char *url,
 
 				free(hostandport);
 				free(path);
+				child_process_clear(conn);
 				free(conn);
 				strbuf_release(&cmd);
 				return NULL;