From: Karel Zak <kzak@redhat.com>
Date: Wed, 15 May 2019 14:01:32 +0000 (+0200)
Subject: lib/path: fix resource leak [coverity scan]
X-Git-Tag: v2.34-rc2~71
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=91bf5817426c34ea3a3f37b291b6b1ba7fe4eb52;p=thirdparty%2Futil-linux.git

lib/path: fix resource leak [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>
---

diff --git a/lib/path.c b/lib/path.c
index 6922e27704..05b608e573 100644
--- a/lib/path.c
+++ b/lib/path.c
@@ -928,6 +928,7 @@ static int ul_path_cpuparse(struct path_cxt *pc, cpu_set_t **set, int maxcpus, i
 	FILE *f;
 	size_t setsize, len = maxcpus * 7;
 	char buf[len];
+	int rc;
 
 	*set = NULL;
 
@@ -935,10 +936,12 @@ static int ul_path_cpuparse(struct path_cxt *pc, cpu_set_t **set, int maxcpus, i
 	if (!f)
 		return -errno;
 
-	if (!fgets(buf, len, f))
-		return -errno;
+	rc = fgets(buf, len, f) == NULL ? -errno : 0;
 	fclose(f);
 
+	if (rc)
+		return rc;
+
 	len = strlen(buf);
 	if (buf[len - 1] == '\n')
 		buf[len - 1] = '\0';