From: Lidong Yan <502024330056@smail.nju.edu.cn>
Date: Mon, 12 May 2025 12:49:04 +0000 (+0000)
Subject: reftable/writer: fix memory leak when `writer_index_hash()` fails
X-Git-Tag: v2.50.0-rc0~28^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=91db6c735dd1da215ae5e12506139f0aba5e426b;p=thirdparty%2Fgit.git

reftable/writer: fix memory leak when `writer_index_hash()` fails

In reftable/writer.c:writer_index_hash(), if `reftable_buf_add` failed,
key allocated by `reftable_malloc` will not be insert into `obj_index_tree`
thus leaks. Simple add reftable_free(key) will solve this problem.

Signed-off-by: Lidong Yan <502024330056@smail.nju.edu.cn>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/reftable/writer.c b/reftable/writer.c
index d71a56e8fc..5de684b36f 100644
--- a/reftable/writer.c
+++ b/reftable/writer.c
@@ -258,8 +258,10 @@ static int writer_index_hash(struct reftable_writer *w, struct reftable_buf *has
 
 		reftable_buf_reset(&key->hash);
 		err = reftable_buf_add(&key->hash, hash->buf, hash->len);
-		if (err < 0)
+		if (err < 0) {
+			reftable_free(key);
 			return err;
+		}
 		tree_insert(&w->obj_index_tree, key,
 			    &obj_index_tree_node_compare);
 	} else {