From: Dylan Van Assche <me@dylanvanassche.be>
Date: Sun, 7 May 2023 17:29:41 +0000 (+0200)
Subject: leds: flash: leds-qcom-flash: Disable LED when changing brightness
X-Git-Tag: v6.5-rc1~79^2~40
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=91fe1bda4672c31aa93d018176e6cf62c6ccb657;p=thirdparty%2Fkernel%2Flinux.git

leds: flash: leds-qcom-flash: Disable LED when changing brightness

The Qualcomm PMI8998 PMIC requires the LED to be disabled when configuring
the brightness. Always disable the LED when setting the brightness and
re-enable it afterwards.

Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
Link: https://lore.kernel.org/r/20230507172941.364852-3-me@dylanvanassche.be
Signed-off-by: Lee Jones <lee@kernel.org>
---

diff --git a/drivers/leds/flash/leds-qcom-flash.c b/drivers/leds/flash/leds-qcom-flash.c
index 16045b5d89b1a..c8d41a3caf387 100644
--- a/drivers/leds/flash/leds-qcom-flash.c
+++ b/drivers/leds/flash/leds-qcom-flash.c
@@ -417,6 +417,14 @@ static int qcom_flash_led_brightness_set(struct led_classdev *led_cdev,
 	bool enable = !!brightness;
 	int rc;
 
+	rc = set_flash_strobe(led, SW_STROBE, false);
+	if (rc)
+		return rc;
+
+	rc = set_flash_module_en(led, false);
+	if (rc)
+		return rc;
+
 	rc = set_flash_current(led, current_ma, TORCH_MODE);
 	if (rc)
 		return rc;