From: Nelson Chu <nelson@rivosinc.com>
Date: Thu, 13 Mar 2025 02:31:34 +0000 (+0800)
Subject: RISC-V: Fixed riscv_update_subset1 returning wrong boolean value
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=921d65b3f0751b714f9859496946e9560001b18f;p=thirdparty%2Fbinutils-gdb.git

RISC-V: Fixed riscv_update_subset1 returning wrong boolean value

The riscv_update_subset1 returning wrong boolean value if the
riscv_parse_check_conflicts isn't called, though the current return value
doesn't really useful.
---

diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c
index fd2cb74df80..ffcf32be69e 100644
--- a/bfd/elfxx-riscv.c
+++ b/bfd/elfxx-riscv.c
@@ -2524,13 +2524,13 @@ riscv_update_subset1 (riscv_parse_subset_t *rps,
     }
   while (*p++ == ',');
 
-  bool conflict = false;
+  bool no_conflict = true;
   if (explicit_subset == NULL)
     {
       riscv_parse_add_implicit_subsets (rps);
-      conflict = riscv_parse_check_conflicts (rps);
+      no_conflict = riscv_parse_check_conflicts (rps);
     }
-  return conflict;
+  return no_conflict;
 }
 
 /* Add/Remove an extension to/from the subset list.  This is used for