From: Timo Sirainen <tss@iki.fi>
Date: Fri, 3 Oct 2014 19:39:53 +0000 (+0300)
Subject: lib-lda: smtp client may have crashed if remote returned a permanent error.
X-Git-Tag: 2.2.14~77
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=924af2adb71a4f740d7f755a59503b358fe9a5d7;p=thirdparty%2Fdovecot%2Fcore.git

lib-lda: smtp client may have crashed if remote returned a permanent error.
---

diff --git a/src/lib-lda/smtp-client.c b/src/lib-lda/smtp-client.c
index ca503eb4cf..08be256b8d 100644
--- a/src/lib-lda/smtp-client.c
+++ b/src/lib-lda/smtp-client.c
@@ -317,8 +317,11 @@ smtp_client_send_flush(struct smtp_client *smtp_client, const char **error_r)
 		i_assert(smtp_client->error != NULL);
 		*error_r = t_strdup(smtp_client->error);
 		return -1;
-	} else
+	} else {
+		i_assert(smtp_client->error != NULL);
+		*error_r = t_strdup(smtp_client->error);
 		return 0;
+	}
 }
 
 int smtp_client_deinit(struct smtp_client *client, const char **error_r)