From: Daniel Stenberg <daniel@haxx.se>
Date: Fri, 19 Apr 2024 08:46:42 +0000 (+0200)
Subject: request: make Curl_req_init return void
X-Git-Tag: curl-8_8_0~182
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=926fb00405e13b2aadd99f678a2c564aadeb2cb7;p=thirdparty%2Fcurl.git

request: make Curl_req_init return void

Since it could not return error and therefore this change removes dead
code for the caller.

Spotted by CodeSonar.

Closes #13423
---

diff --git a/lib/request.c b/lib/request.c
index d1605d32a1..26741fa6cb 100644
--- a/lib/request.c
+++ b/lib/request.c
@@ -40,10 +40,9 @@
 #include "curl_memory.h"
 #include "memdebug.h"
 
-CURLcode Curl_req_init(struct SingleRequest *req)
+void Curl_req_init(struct SingleRequest *req)
 {
   memset(req, 0, sizeof(*req));
-  return CURLE_OK;
 }
 
 CURLcode Curl_req_soft_reset(struct SingleRequest *req,
diff --git a/lib/request.h b/lib/request.h
index 488fbdd4d9..f9be6f2993 100644
--- a/lib/request.h
+++ b/lib/request.h
@@ -152,7 +152,7 @@ struct SingleRequest {
 /**
  * Initialize the state of the request for first use.
  */
-CURLcode Curl_req_init(struct SingleRequest *req);
+void Curl_req_init(struct SingleRequest *req);
 
 /**
  * The request is about to start. Record time and do a soft reset.
diff --git a/lib/url.c b/lib/url.c
index e11d80327c..fc3a4356e4 100644
--- a/lib/url.c
+++ b/lib/url.c
@@ -516,12 +516,7 @@ CURLcode Curl_open(struct Curl_easy **curl)
 
   data->magic = CURLEASY_MAGIC_NUMBER;
 
-  result = Curl_req_init(&data->req);
-  if(result) {
-    DEBUGF(fprintf(stderr, "Error: request init failed\n"));
-    free(data);
-    return result;
-  }
+  Curl_req_init(&data->req);
 
   result = Curl_resolver_init(data, &data->state.async.resolver);
   if(result) {