From: Maxime Ripard Date: Mon, 7 Apr 2025 16:29:07 +0000 (+0200) Subject: dma-buf: heaps: system: Remove global variable X-Git-Tag: v6.16-rc1~144^2~21^2~7 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=92a2bf257ec4729d13ed17f5b04192ad8e3b7024;p=thirdparty%2Flinux.git dma-buf: heaps: system: Remove global variable The system heap is storing its struct dma_heap pointer in a global variable but isn't using it anywhere. Let's move the global variable into system_heap_create() to make it local. Signed-off-by: Maxime Ripard Reviewed-by: Christian König Reviewed-by: Mattijs Korpershoek Link: https://patchwork.freedesktop.org/patch/msgid/20250407-dma-buf-ecc-heap-v3-1-97cdd36a5f29@kernel.org Signed-off-by: Christian König --- diff --git a/drivers/dma-buf/heaps/system_heap.c b/drivers/dma-buf/heaps/system_heap.c index 26d5dc89ea166..82b1b714300d6 100644 --- a/drivers/dma-buf/heaps/system_heap.c +++ b/drivers/dma-buf/heaps/system_heap.c @@ -21,8 +21,6 @@ #include #include -static struct dma_heap *sys_heap; - struct system_heap_buffer { struct dma_heap *heap; struct list_head attachments; @@ -424,6 +422,7 @@ static const struct dma_heap_ops system_heap_ops = { static int __init system_heap_create(void) { struct dma_heap_export_info exp_info; + struct dma_heap *sys_heap; exp_info.name = "system"; exp_info.ops = &system_heap_ops;