From: Mike Frysinger <vapier@gentoo.org>
Date: Wed, 3 Jan 2024 08:38:35 +0000 (-0500)
Subject: sim: ppc: workaround uninitialized variable compiler warnings
X-Git-Tag: binutils-2_42~201
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=92bdeb2888729eec6e699ef1cf5c3fc4c2db886e;p=thirdparty%2Fbinutils-gdb.git

sim: ppc: workaround uninitialized variable compiler warnings

Some compilers don't understand the semctl API and think it's an input
argument even when it's used as an output, and then complains that it
is being used uninitialized.  Zero it out explicitly to workaround it.
This adds some runtime overhead, but should be fairly minor as it's a
small stack buffer, and shouldn't be that relevant relative to all the
other logic in these functions.
---

diff --git a/sim/ppc/hw_sem.c b/sim/ppc/hw_sem.c
index c43af3b1d9e..9495b8591b9 100644
--- a/sim/ppc/hw_sem.c
+++ b/sim/ppc/hw_sem.c
@@ -111,7 +111,7 @@ hw_sem_init_data(device *me)
   hw_sem_device *sem = (hw_sem_device*)device_data(me);
   const device_unit *d;
   int status;
-  union semun help;
+  union semun help = {};
 
   /* initialize the properties of the sem */
 
@@ -190,7 +190,7 @@ hw_sem_io_read_buffer(device *me,
   struct sembuf sb;
   int status;
   uint32_t u32;
-  union semun help;
+  union semun help = {};
 
   /* do we need to worry about out of range addresses? */