From: Jules Irenge <jbi.octave@gmail.com>
Date: Thu, 30 Jan 2020 00:30:09 +0000 (+0000)
Subject: rcu/nocb: Add missing annotation for rcu_nocb_bypass_unlock()
X-Git-Tag: v5.7-rc1~183^2^2^2~5
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=92c0b889f2ff6898710d49458b6eae1de50895c6;p=thirdparty%2Flinux.git

rcu/nocb: Add missing annotation for rcu_nocb_bypass_unlock()

Sparse reports warning at rcu_nocb_bypass_unlock()

warning: context imbalance in rcu_nocb_bypass_unlock() - unexpected unlock

The root cause is a missing annotation of rcu_nocb_bypass_unlock()
which causes the warning.

This commit therefore adds the missing __releases(&rdp->nocb_bypass_lock)
annotation.

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Acked-by: Boqun Feng <boqun.feng@gmail.com>
---

diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
index 6db2cad7dab76..384651915d741 100644
--- a/kernel/rcu/tree_plugin.h
+++ b/kernel/rcu/tree_plugin.h
@@ -1530,6 +1530,7 @@ static bool rcu_nocb_bypass_trylock(struct rcu_data *rdp)
  * Release the specified rcu_data structure's ->nocb_bypass_lock.
  */
 static void rcu_nocb_bypass_unlock(struct rcu_data *rdp)
+	__releases(&rdp->nocb_bypass_lock)
 {
 	lockdep_assert_irqs_disabled();
 	raw_spin_unlock(&rdp->nocb_bypass_lock);