From: Mario Limonciello (AMD) <superm1@kernel.org>
Date: Thu, 9 Oct 2025 16:17:54 +0000 (-0500)
Subject: cpufreq/amd-pstate: Adjust return values in amd_pstate_update_status()
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=92d6146a40b2d5ce0b9dcc7b3ff28d57b4757ed1;p=thirdparty%2Flinux.git

cpufreq/amd-pstate: Adjust return values in amd_pstate_update_status()

get_mode_idx_from_str() already checks the upper boundary for a string
sent.  Drop the extra check in amd_pstate_update_status() and pass
the return code if there is a failure.

Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
---

diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
index 5feb9f5e3a491..2d2ef53d12447 100644
--- a/drivers/cpufreq/amd-pstate.c
+++ b/drivers/cpufreq/amd-pstate.c
@@ -1346,9 +1346,8 @@ int amd_pstate_update_status(const char *buf, size_t size)
 		return -EINVAL;
 
 	mode_idx = get_mode_idx_from_str(buf, size);
-
-	if (mode_idx < 0 || mode_idx >= AMD_PSTATE_MAX)
-		return -EINVAL;
+	if (mode_idx < 0)
+		return mode_idx;
 
 	if (mode_state_machine[cppc_state][mode_idx]) {
 		guard(mutex)(&amd_pstate_driver_lock);