From: Rubén Justo <rjusto@gmail.com>
Date: Tue, 13 Feb 2024 23:36:38 +0000 (+0100)
Subject: tag: error when git-column fails
X-Git-Tag: v2.45.0-rc0~166^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=92e66478fc0f1e03ff8e49d66ebe84b1d98b7a90;p=thirdparty%2Fgit.git

tag: error when git-column fails

If the user asks for the list of tags to be displayed in columns
("--columns"), a child git-column process is used to format the output
as expected.

In a rare situation where we encounter a problem spawning that child
process, we will work erroneously.

Make noticeable we're having a problem executing git-column, so the user
can act accordingly.

Signed-off-by: Rubén Justo <rjusto@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/builtin/tag.c b/builtin/tag.c
index d428c45dc8..53f8bfd907 100644
--- a/builtin/tag.c
+++ b/builtin/tag.c
@@ -537,7 +537,8 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
 			struct column_options copts;
 			memset(&copts, 0, sizeof(copts));
 			copts.padding = 2;
-			run_column_filter(colopts, &copts);
+			if (run_column_filter(colopts, &copts))
+				die(_("could not start 'git column'"));
 		}
 		filter.name_patterns = argv;
 		ret = list_tags(&filter, sorting, &format);